gh-110964: clinic: refactor output_templates()#110982
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Oct 17, 2023
Refactor the code to avoid |
vstinnerforce-pushed the clinic_output_templates branch from 3f5b550 to e6cebdbCompareMemberAuthor
vstinner commented Oct 17, 2023
cc @AlexWaygood |
erlend-aasland approved these changes Oct 20, 2023
Contributor
erlend-aasland left a comment
erlend-aasland left a comment There was a problem hiding this comment.
Are you fine with this, @AlexWaygood?
Member
AlexWaygood commented Oct 20, 2023
Haven't had a chance to review in depth, but this looks fine to me -- feel free to merge if you're happy! |
MemberAuthor
vstinner commented Oct 20, 2023
Merged, thanks for reviews. |
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.