gh-85283: Fix _ctypes_test build on Windows in release mode#111005
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MemberAuthor
vstinner commented Oct 17, 2023
Extract of # if defined(_DEBUG) # pragma comment(lib,"python313_d.lib") # elif defined(Py_LIMITED_API) # pragma comment(lib,"python3.lib") # else# pragma comment(lib,"python313.lib") # endif/* _DEBUG */In debug mode, extensions are always linked to |
Define Py_BUILD_CORE to not attempt to link the extension to python3.lib (which fails).
vstinnerforce-pushed the ctypes_test_core branch from d4aacd3 to 09c9071Compareaisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…thon#111005) Define Py_BUILD_CORE to not attempt to link the extension to python3.lib (which fails).
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…thon#111005) Define Py_BUILD_CORE to not attempt to link the extension to python3.lib (which fails).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define Py_BUILD_CORE to not attempt to link the extension to python3.lib (which fails).