Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Oct 22, 2023

Working on a full description of what is going on.

#111181


📚 Documentation preview 📚: https://cpython-previews--111180.org.readthedocs.build/

@sobolevnsobolevn changed the title Fix enum doctestsgh-111181: Fix enum doctestsOct 22, 2023
@sobolevn
Copy link
MemberAuthor

sobolevn commented Oct 22, 2023

@ethanfurman as I said I am not sure that my fixes are correct, I just want to show you that there are some broken tests at the moment. I need your help with the details :)

@serhiy-storchakaserhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Oct 23, 2023
@ethanfurman
Copy link
Member

Thank you for getting the doc tests to always run. I'll work on getting the doc tests correct.

@ethanfurmanethanfurman self-assigned this Oct 23, 2023
@sobolevnsobolevn marked this pull request as ready for review October 28, 2023 06:03
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @ethanfurman, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c4dc5a6ae8aa13abb743182df088f1a3526d1bcd 3.11 

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2023
(cherry picked from commit c4dc5a6) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@bedevere-app
Copy link

GH-111518 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Oct 30, 2023
ethanfurman added a commit that referenced this pull request Oct 31, 2023
gh-111181: Fix enum doctests (GH-111180) (cherry picked from commit c4dc5a6) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit to ethanfurman/cpython that referenced this pull request Nov 1, 2023
Co-authored-by: Ethan Furman <ethan@stoneleaf.us> (cherry picked from commit c4dc5a6)
@bedevere-app
Copy link

GH-111617 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Nov 1, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ethanfurman added a commit that referenced this pull request Nov 3, 2023
gh-111181: Fix enum doctests (GH-111180) Co-authored-by: Ethan Furman <ethan@stoneleaf.us> (cherry picked from commit c4dc5a6) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@ethanfurman@serhiy-storchaka