[3.12] gh-110205: Fix asyncio ThreadedChildWatcher._join_threads() (GH-110884)#111412
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…thonGH-110884) - `ThreadedChildWatcher.close()` is now *officially* a no-op; `_join_threads()` never did anything. - Threads created by that class are now named `asyncio-waitpid-NNN`. - `test.test_asyncio.utils.TestCase.close_loop()` now waits for the child watcher's threads, but not forever; if a thread hangs, it raises `RuntimeError`. (cherry picked from commit c3bb10c) Co-authored-by: Guido van Rossum <[email protected]>
miss-islington requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners
gvanrossum approved these changes Oct 27, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThreadedChildWatcher.close()is now officially a no-op;_join_threads()never did anything.asyncio-waitpid-NNN.test.test_asyncio.utils.TestCase.close_loop()now waits for the child watcher's threads, but not forever; if a thread hangs, it raisesRuntimeError.(cherry picked from commit c3bb10c)
Co-authored-by: Guido van Rossum [email protected]