Skip to content

GH-111339: Move optimizer types to object.c#111430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brandtbucher merged 5 commits into from
Oct 29, 2023
Merged

GH-111339: Move optimizer types to object.c#111430

brandtbucher merged 5 commits into from
Oct 29, 2023

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowskisavannahostrowski commented Oct 28, 2023•
edited by bedevere-app bot
Loading

This PR moves types defined in optimizer.c to static_types in object.c per @brandtbucher's hunch. I tried to abide by the naming conventions of the other types in static_types by updating names to be prefixed by _Py. Please let me know if this is incorrect.

I've tested this and I can no longer reproduce the assertion error.

@bedevere-appbedevere-appbot mentioned this pull request Oct 28, 2023
Closed
@savannahostrowskisavannahostrowski changed the title GH-111339: Add optimizer types to object.cGH-111339: Move optimizer types to object.cOct 28, 2023
@savannahostrowskisavannahostrowski changed the title GH-111339: Move optimizer types to object.cGH-111339: Move optimizer types to object.cOct 28, 2023
@brandtbucherbrandtbucher self-assigned this Oct 28, 2023
brandtbucher
brandtbucher reviewed Oct 28, 2023
View reviewed changes
Copy link
Member

@brandtbucherbrandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is solid, thanks. And great instinct with the renaming!

There's nothing wrong with this, just a few observations:

@brandtbucherbrandtbucher added type-bug An unexpected behavior, bug, or error skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Oct 28, 2023
@brandtbucher
Copy link
Member

brandtbucher commented Oct 28, 2023

(I think these types may need to be added to an ignore-list somewhere? I think the failing check has more info.)

Savannah Ostrowskiand others added 3 commits October 28, 2023 19:58
@brandtbucher
Update object.c
e192140
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@brandtbucher
Update pycore_optimizer.h
a65aeff
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@savannahostrowski
Update types in ignored.tsv
f064a53
@brandtbucherbrandtbucher merged commit 4a929d4 into python:mainOct 29, 2023
@savannahostrowskisavannahostrowski deleted the fix-111339 branch October 30, 2023 16:11
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@savannahostrowski@FullteaR
pythonGH-111339: Fix initialization and finalization of static optimi…
9241827
…zer types (pythonGH-111430)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@savannahostrowski@aisk
pythonGH-111339: Fix initialization and finalization of static optimi…
151fb9d
…zer types (pythonGH-111430)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@savannahostrowski@Glyphack
pythonGH-111339: Fix initialization and finalization of static optimi…
1608a04
…zer types (pythonGH-111430)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

Assignees

@brandtbucherbrandtbucher

Labels

interpreter-core(Objects, Python, Grammar, and Parser dirs)skip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@savannahostrowski@brandtbucher