gh-66425: Remove the unreachable code to set REMOTE_HOST header#111441
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… from wsgiref module
All commit authors signed the Contributor License Agreement. |
corona10 approved these changes Oct 29, 2023
Member
corona10 left a comment
corona10 left a comment There was a problem hiding this comment.
LGTM, Even if someone overrides WSGIRequestHandler there is the documentation that the user should care about: https://docs.python.org/3/library/wsgiref.html?highlight=wsgirequesthandler#wsgiref.simple_server.WSGIRequestHandler
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Oct 29, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@corona10 Hi Donghee. Thank you for leading the CPython dev. sprint at PyCon APAC 2023. This patch does not contain additional test code because it only removes the unreachable lines; there are no changes in behavior.
Please refer to https://www.rfc-editor.org/rfc/rfc3875#page-16 about
REMOTE_HOSTheader.