Skip to content

gh-111062: Separate linux build into a reusable workflow#111446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NCLI wants to merge 19 commits into from
Closed

gh-111062: Separate linux build into a reusable workflow #111446

NCLI wants to merge 19 commits into from

Conversation

@NCLI
Copy link
Contributor

@NCLINCLI commented Oct 29, 2023•
edited by bedevere-app bot
Loading

@bedevere-app
Copy link

bedevere-appbot commented Oct 29, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-appbedevere-appbot mentioned this pull request Oct 29, 2023
Closed
@bedevere-app

This comment was marked as resolved.

Sign in to view
dimaqq
dimaqq reviewed Oct 29, 2023
View reviewed changes
.github/workflows/reusable-build-ubuntu.yml Outdated
@@ -0,0 +1,84 @@
name: Tests
Copy link
Contributor

@dimaqqdimaqqOct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

dimaqq
dimaqq reviewed Oct 29, 2023
View reviewed changes
.github/workflows/reusable-build-ubuntu.yml Outdated
contents: read

jobs:
name: 'Ubuntu reusable'
Copy link
Contributor

@dimaqqdimaqqOct 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10 says remove this name

@NCLINCLI changed the title GH-111062 Reusable ubuntu workflowfor build testGH-111062 Separate linux build into a reusable workflowOct 29, 2023
dimaqq
dimaqq approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@dimaqqdimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine 😄

@NCLINCLI marked this pull request as ready for review October 29, 2023 07:00
@NCLINCLI requested a review from hugovk as a code ownerOctober 29, 2023 07:00
@dimaqqdimaqq mentioned this pull request Oct 29, 2023
Closed
@hugovkhugovk changed the title GH-111062 Separate linux build into a reusable workflowgh-111062: Separate linux build into a reusable workflowOct 29, 2023
@hugovk
Copy link
Member

hugovk commented Oct 29, 2023

Looking good, let's first decide on the name, re: #111062 (comment)

reusable-build-ubuntu.yml, or reusable-ubuntu.yml to match reusable-docs.yml?

@corona10
Copy link
Member

corona10 commented Oct 30, 2023

Duplicated with #111452

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

1 more reviewer

@dimaqqdimaqqdimaqq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hugovkhugovk

Labels

awaiting reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NCLI@hugovk@corona10@dimaqq