gh-76785: Move the Cross-Interpreter Code to Its Own File#111502
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Eclips4 reviewed Oct 30, 2023
Uh oh!
There was an error while loading. Please reload this page.
vstinner approved these changes Oct 30, 2023
| }; | ||
| PyAPI_FUNC(_PyCrossInterpreterData *) _PyCrossInterpreterData_New(void); | ||
| PyAPI_FUNC(void) _PyCrossInterpreterData_Free(_PyCrossInterpreterData *data); |
Member
There was a problem hiding this comment.
If you don't need one of these functions in shared libraries (stdlib extensions), you can replace PyAPI_FUNC() with extern.
MemberAuthor
There was a problem hiding this comment.
They're basically all used in _xxsubinterpretersmodule.c and _xxinterpchannelsmodule.c.
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
…ongh-111502) This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ongh-111502) This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ongh-111502) This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c. This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partly to clear this stuff out of pystate.c, but also in preparation for moving some code out of _xxsubinterpretersmodule.c.
This change also moves this stuff to the internal API (new: Include/internal/pycore_crossinterp.h). @vstinner did this previously and I undid it. Now I'm re-doing it. :/
(This PR essentially only moves existing code between files.)