Skip to content

gh-110481: Fix _Py_ThreadId for non-free-threaded mode#111503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 1 commit into from
Oct 30, 2023
Merged

gh-110481: Fix _Py_ThreadId for non-free-threaded mode #111503

corona10 merged 1 commit into from
Oct 30, 2023

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Oct 30, 2023•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Oct 30, 2023
Closed
@corona10corona10 added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting core review labels Oct 30, 2023
@bedevere-bot
Copy link

bedevere-bot commented Oct 30, 2023

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 8ef44ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@corona10corona10 added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 30, 2023
@bedevere-bot
Copy link

bedevere-bot commented Oct 30, 2023

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 8ef44ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@corona10corona10 reopened this Oct 30, 2023
@corona10corona10 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@bedevere-bot
Copy link

bedevere-bot commented Oct 30, 2023

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 8ef44ef 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 30, 2023
@corona10corona10 changed the title gh-110481: Fix build bot for free-threaded modegh-110481: Fix build bot for non-free-threaded modeOct 30, 2023
@corona10corona10 mentioned this pull request Oct 30, 2023
Merged
vstinner
vstinner reviewed Oct 30, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh-110481: Fix build bot for non-free-threaded mode #111503

Please don't mention buildbot, but mention the fixed function: _Py_ThreadId().

@corona10corona10 changed the title gh-110481: Fix build bot for non-free-threaded modegh-110481: Fix _Py_ThreadId for non-free-threaded modeOct 30, 2023
@corona10
Copy link
MemberAuthor

corona10 commented Oct 30, 2023

Please don't mention buildbot, but mention the fixed function: _Py_ThreadId().

Good! I updated the PR title too.

@vstinner
Copy link
Member

vstinner commented Oct 30, 2023

s390x RHEL7 LTO + PGO 3.x failed on PR #110764, but pass with this PR: so this PR fix the buildbot.

vstinner
vstinner approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10corona10 merged commit 55df2de into python:mainOct 30, 2023
@corona10corona10 deleted the gh-110481-fix-build-bot branch October 30, 2023 17:16
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
@corona10@FullteaR
pythongh-110481: Fix _Py_ThreadId for non-free-threaded mode (pythong…
2efd0c7
…h-111503)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10@aisk
pythongh-110481: Fix _Py_ThreadId for non-free-threaded mode (pythong…
7ce13c1
…h-111503)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10@Glyphack
pythongh-110481: Fix _Py_ThreadId for non-free-threaded mode (pythong…
8a0a8b8
…h-111503)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@colesburycolesburycolesbury approved these changes

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@corona10@bedevere-bot@vstinner@colesbury