Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Oct 30, 2023

Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc).

Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().

Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
@vstinner
Copy link
MemberAuthor

I tested that no warnings is emitted with these 4 configurations:

pyconfigure_debug --with-pymalloc --with-mimalloc && make clean && make pyconfigure_debug --with-pymalloc --without-mimalloc && make clean && make pyconfigure_debug --without-pymalloc --with-mimalloc && make clean && make pyconfigure_debug --without-pymalloc --without-mimalloc && make clean && make 

with:

$ alias pyconfigure_debug alias pyconfigure_debug='./configure --cache-file=../python-config.cache --with-pydebug CFLAGS=-O0 --with-system-expat' 

@vstinnervstinner merged commit da4d314 into python:mainOct 30, 2023
@vstinnervstinner deleted the mimalloc branch October 30, 2023 22:05
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
…#111522) Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…#111522) Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…#111522) Don't declare _PyMem_MimallocEnabled() if WITH_PYMALLOC macro is not defined (./configure --without-pymalloc). Fix also a typo in _PyInterpreterState_FinalizeAllocatedBlocks().
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner