gh-90815: Exclude mimalloc .c files from Windows build#111532
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
vstinner commented Oct 31, 2023
There are some compiler warnings: 'fprintf' : format string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'unsigned __int64' [D:\a\cpython\cpython\PCbuild\pythoncore.vcxproj] |
Member
vstinner commented Oct 31, 2023
Tests pass! |
corona10 changed the title 
vstinner approved these changes Oct 31, 2023
Member
vstinner left a comment
vstinner left a comment There was a problem hiding this comment.
LGTM. Objects/obmalloc.c uses #include "pycore_mimalloc.h", so already includes mimalloc code "statically".
Member
vstinner commented Oct 31, 2023
I don't click on "Enable auto-merge", since I would like to see if the warnings are gone ;-) |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
DinoVforce-pushed the nogil/mimalloc_windows branch from 846b2af to 7894ccaCompareFullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
…111532) * Don't include mimalloc .c's in Windows build * Fix warnings on Windows related to mimalloc
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…111532) * Don't include mimalloc .c's in Windows build * Fix warnings on Windows related to mimalloc
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…111532) * Don't include mimalloc .c's in Windows build * Fix warnings on Windows related to mimalloc
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove mimalloc .c files from Windows build