gh-111495: Add tests for PyComplex C API#111591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

serhiy-storchaka merged 16 commits into python:main from skirpichev:capi-complex-tests

Nov 5, 2023

Member

skirpichev commented Nov 1, 2023•
edited by bedevere-app bot
Loading

Issue: Add more C API tests #111495

MemberAuthor

skirpichev commented Nov 1, 2023•
edited
Loading

~~On top of #111586 - that's why marked as a draft pr.~~

skirpichev mentioned this pull request

Add more C API tests #111495

Closed

10 tasks

pythongh-111495: Add tests for PyComplex C API

b88f657

skirpichev force-pushed the capi-complex-tests branch from 637b759 to b88f657Compare

November 1, 2023 06:25

skirpichev changed the title ~~Add tests for PyComplex C API~~gh-111495: Add tests for PyComplex C API

skirpichev marked this pull request as ready for review

November 1, 2023 06:26

bedevere-appbot added the awaiting review label

Simplify complex_fromdoubles()

9f04bcb

serhiy-storchaka self-requested a review

November 1, 2023 14:28

serhiy-storchaka reviewed

View reviewed changes

Lib/test/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_complex.py Outdated Show resolvedHide resolved

skirpichev added 2 commits

November 1, 2023 18:30

Use assertEqual()

d19a9d4

Move tests to Lib/test/test_capi/test_complex.py

c8adbd2

skirpichev requested a review from serhiy-storchaka

November 1, 2023 15:36

skirpichev mentioned this pull request

gh-109598: make PyComplex_RealAsDouble/ImagAsDouble use __complex__ #109647

Merged

skirpichev added 2 commits

November 2, 2023 07:06

Add missing coverage tests

6ead74b

Cleanup, add comments

67fb214

skirpichev mentioned this pull request

Shouldn't Sir classify changes in test modules by "tests" label? python/bedevere#605

Closed

serhiy-storchaka reviewed

View reviewed changes

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Modules/_testcapi/complex.c Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

AlexWaygood added tests skip news labels

skirpichev commented

View reviewed changes

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

skirpichev commented

View reviewed changes

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

skirpichev commented

View reviewed changes

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

skirpichev commented

View reviewed changes

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

skirpichev commented

View reviewed changes

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

skirpichevand others added 2 commits

November 4, 2023 14:27

Apply suggestions from code review

7694c60

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

+1

70796bd

serhiy-storchaka reviewed

View reviewed changes

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

skirpichev added 2 commits

November 4, 2023 15:12

Correct typos and wrongly added test

5c1cd4f

Drop comments

20e37e5

Use PyComplex_AsCComplex() in complex_fromccomplex()

b743f4b

skirpichev mentioned this pull request

gh-111495: Add tests for PyFloat C API #111624

Merged

skirpichev added 2 commits

November 4, 2023 18:07

Merge branch 'main' into capi-complex-tests

89a18ff

Use PyArg_Parse('D') instead

34347fa

skirpichev requested a review from serhiy-storchaka

November 4, 2023 15:33

serhiy-storchaka reviewed

View reviewed changes

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

skirpichev added 2 commits

November 5, 2023 04:43

s/3.14/4.25/g

09f5246

Reorder statements in test_as* and add an integer test for imagasdoub…

3682e51

…le()

skirpichev requested a review from serhiy-storchaka

November 5, 2023 02:08

serhiy-storchaka reviewed

View reviewed changes

Lib/test/test_capi/test_complex.py Outdated Show resolvedHide resolved

Lib/test/test_capi/test_complex.pyShow resolvedHide resolved

Apply suggestions from code review

a4981d6

serhiy-storchaka approved these changes

View reviewed changes

Member

serhiy-storchaka left a comment

LGTM.

bedevere-appbot added awaiting merge and removed awaiting review labels

serhiy-storchaka added topic-C-API needs backport to 3.12 labels

serhiy-storchaka enabled auto-merge (squash)

November 5, 2023 07:21

serhiy-storchaka merged commit 24b5cbd into python:main

bedevere-appbot removed the awaiting merge label

miss-islington-appbot commented Nov 5, 2023

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

pythongh-111495: Add tests for PyComplex C API (pythonGH-111591)

269b69d

(cherry picked from commit 24b5cbd) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

bedevere-appbot commented Nov 5, 2023

GH-111753 is a backport of this pull request to the 3.12 branch.

bedevere-appbot removed the needs backport to 3.12 label

serhiy-storchaka pushed a commit that referenced this pull request

[3.12]gh-111495: Add tests for PyComplex C API (GH-111591) (GH-111753)

e0c2bf4

(cherry picked from commit 24b5cbd) Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>

skirpichev deleted the capi-complex-tests branch

November 5, 2023 09:58

skirpichev added a commit to skirpichev/cpython that referenced this pull request

Merge branch 'main' into complex-realimag-asdouble

6be9ee2

This include python#111591

skirpichev mentioned this pull request

gh-109802: removed inaccessible code from complexobject.c #109642

Closed

aisk pushed a commit to aisk/cpython that referenced this pull request

pythongh-111495: Add tests for PyComplex C API (pythonGH-111591)

cc255cb

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

pythongh-111495: Add tests for PyComplex C API (pythonGH-111591)

7748a29

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment