Skip to content

Conversation

@rawwar
Copy link
Contributor

@rawwarrawwar commented Nov 1, 2023

Adding tests for PyTuple C API - Issue #111495

Signed-off-by: kalyanr <kalyan.ben10@live.com>
@bedevere-appbedevere-appbot mentioned this pull request Nov 1, 2023
10 tasks
@bedevere-appbedevere-appbot added the tests Tests in the Lib/test dir label Nov 1, 2023
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
Signed-off-by: kalyanr <kalyan.ben10@live.com>
@rawwar
Copy link
ContributorAuthor

Hello @serhiy-storchaka , I am not sure how to write tests for the following C API's. Can you please help me with some ideas. Thanks!

  1. PyTuple_Pack
  2. PyTuple_SetItem
  3. PyTuple_SET_ITEM
  4. PyTuple_Resize

@rawwarrawwar marked this pull request as ready for review November 1, 2023 19:27
@rawwarrawwar marked this pull request as draft November 4, 2023 04:01
@skirpichev
Copy link
Member

@rawwar, are you working on this? Regarding ideas, you could take look on other tests for C-API, e.g. for lists.

@rawwar
Copy link
ContributorAuthor

rawwar commented Feb 21, 2024

@rawwar, are you working on this? Regarding ideas, you could take look on other tests for C-API, e.g. for lists.

Thanks. I will go through them. Will be looking into this over the weekend

@rawwar
Copy link
ContributorAuthor

I won't be able to complete this PR at this time.

@rawwarrawwar closed this May 8, 2024
@skirpichev
Copy link
Member

I'll try to finish your work.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testsTests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rawwar@skirpichev