Skip to content

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Nov 2, 2023

Surprisingly, PyLong_Type doesn't implement vectorcall, so this PR adds it.
It should improve performance a bit and I need int(True) to stay on trace to test #109369

returnlong_new_impl(_PyType_CAST(type), args[0], args[1]);
default:
returnPyErr_Format(PyExc_TypeError,
"int expected at most 2 argument%s, got %zd", nargs);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the indentation right here?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not. I'll fix it

@markshannonmarkshannon merged commit 0887b9c into python:mainNov 2, 2023
FullteaR pushed a commit to FullteaR/cpython that referenced this pull request Nov 3, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@markshannonmarkshannon deleted the long-vectorcall branch August 6, 2024 10:17
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@eendebakpt@iritkatriel