Skip to content

gh-111789: Use PyDict_GetItemRef() in Objects/#111827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 7 commits into from
Nov 14, 2023
Merged

gh-111789: Use PyDict_GetItemRef() in Objects/ #111827

serhiy-storchaka merged 7 commits into from
Nov 14, 2023

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Nov 7, 2023•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Nov 7, 2023
Closed
@vstinner
Copy link
Member

vstinner commented Nov 8, 2023

Ping me when this PR is ready for a review. Now it's marked as a draft.

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Nov 8, 2023

It is ready for review. I marked is as draft because I do not insist that all these changes should be applied.

@serhiy-storchakaserhiy-storchaka marked this pull request as ready for review November 8, 2023 17:47
serhiy-storchaka
serhiy-storchaka commented Nov 13, 2023
View reviewed changes
vstinner
vstinner previously approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

@vstinnervstinner dismissed their stale reviewNovember 13, 2023 14:16

oops, there is a bug, i should not approve the PR

@vstinner
Copy link
Member

vstinner commented Nov 13, 2023

LGTM with some suggestions

Sorry, _PyObject_GenericGetAttrWithDict() should be fixed before I can approve the PR.

serhiy-storchaka
serhiy-storchaka commented Nov 13, 2023
View reviewed changes
vstinner
vstinner approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Nov 13, 2023

Thank you for your review, Victor. I applied all your suggestions.

@serhiy-storchakaserhiy-storchaka merged commit 18203a6 into python:mainNov 14, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka@aisk
pythongh-111789: Use PyDict_GetItemRef() in Objects/ (pythonGH-111827)
9c401c0
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka@Glyphack
pythongh-111789: Use PyDict_GetItemRef() in Objects/ (pythonGH-111827)
ed707d4
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@vstinner