Skip to content

gh-111789: Use PyDict_GetItemRef() in _ctypes#111828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 4 commits into from
Nov 14, 2023
Merged

gh-111789: Use PyDict_GetItemRef() in _ctypes #111828

serhiy-storchaka merged 4 commits into from
Nov 14, 2023

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Nov 7, 2023•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Nov 7, 2023
Closed
@vstinner
Copy link
Member

vstinner commented Nov 8, 2023

Ping me when this PR is ready for review. Now it's marked as a draft.

@serhiy-storchaka
Copy link
MemberAuthor

serhiy-storchaka commented Nov 8, 2023

It is ready for review. I marked it as draft because I do not insist that all these changes should be applied.

@serhiy-storchakaserhiy-storchaka marked this pull request as ready for review November 8, 2023 17:47
vstinner
vstinner approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Modules/_ctypes/_ctypes.c
}
*presult = NULL;
return 0;
int rc = PyDict_GetItemRef(dict, key, presult);
Copy link
Member

@vstinnervstinnerNov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_PyDict_GetItemProxy() now returns 1 if PyDict_GetItemRef() returns 1 and PyWeakref_CheckProxy() is false. It's only called once with if (_PyDict_GetItemProxy(cache, key, &result) != 0){. So it's ok.

Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchakaNov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it has the same semantic as PyDict_GetItemRef().

1 -- found, returns a strong reference
0 -- not found (or was destroyed)
-1 -- error

serhiy-storchaka
serhiy-storchaka commented Nov 13, 2023
View reviewed changes
Modules/_ctypes/_ctypes.c
}
*presult = NULL;
return 0;
int rc = PyDict_GetItemRef(dict, key, presult);
Copy link
MemberAuthor

@serhiy-storchakaserhiy-storchakaNov 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it has the same semantic as PyDict_GetItemRef().

1 -- found, returns a strong reference
0 -- not found (or was destroyed)
-1 -- error

@serhiy-storchakaserhiy-storchaka merged commit c98600b into python:mainNov 14, 2023
@serhiy-storchakaserhiy-storchaka deleted the use-dict_getitemref-in-ctypes branch November 14, 2023 09:28
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka@aisk
pythongh-111789: Use PyDict_GetItemRef() in _ctypes (pythonGH-111828)
cbb5c71
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka@Glyphack
pythongh-111789: Use PyDict_GetItemRef() in _ctypes (pythonGH-111828)
9cd8a0d
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@vstinner