Skip to content

Conversation

@hugovk
Copy link
Member

A suggestion for gh-111863, following the pattern of the --disable-gil flag.

cc @colesbury

@pitrou
Copy link
Member

Then I would suggest Py_GIL_DISABLED (using a noun + adjective, rather than a verb, for a constant).

@colesbury
Copy link
Contributor

Thanks @hugovk. I would like some comment first from the Python steering council about the preferred name so that:

  1. We don't need to change it again in the future.
  2. We don't spend too much time bikeshedding the name.

Beyond that, we'll also need to change pypa/packaging as it uses sysconfig.get_config_var("Py_NOGIL"), which comes from the macro defined in configure.

@gpshead
Copy link
Member

The SC threw our xkcd-randomized dart at the dartboard of bikeshed names: it landed on Py_GIL_DISABLED.

@hugovkhugovk removed the request for review from gvanrossumNovember 20, 2023 09:45
@hugovk
Copy link
MemberAuthor

Thanks, updated to use Py_GIL_DISABLED.

@hugovkhugovk changed the title gh-111863: Rename Py_NOGIL to Py_DISABLE_GILgh-111863: Rename Py_NOGIL to Py_GIL_DISABLEDNov 20, 2023
@Yhg1s
Copy link
Member

This created a file in Misc/NEWS.d/next/C_API, presumably by accident. The actual directory should be Misc/NEWS.d/next/"C API" (a space instead of an underscore). Was the blurb file created by hand, or is this a bug in blurb or blurb-it?

aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
ambv added a commit to python/peps that referenced this pull request Mar 6, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.13bugs and security fixestopic-free-threading

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@hugovk@pitrou@colesbury@gpshead@Yhg1s