gh-111903: Add @critical_section directive to Argument Clinic.#111904
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The `@critical_section` directive instructs Argument Clinic to generate calls to `Py_BEGIN_CRITICAL_SECTION()` and `Py_END_CRITICAL_SECTION()` around the bound function. In `--disable-gil` builds, these calls will lock and unlock the `self` object. They are no-ops in the default build. This is used in one place (`_io._Buffered.close`) as a demonstration. Subsequent PRs will use it more widely in the `_io.Buffered` bindings.
colesbury added topic-argument-clinic 3.13 
Contributor
erlend-aasland commented Nov 10, 2023
Thanks! Can you please add tests? Also, we need to update the docs over at the devguide. Can you prepare a PR for that? |
ContributorAuthor
colesbury commented Nov 10, 2023
I added two tests to |
erlend-aasland approved these changes Nov 14, 2023
Contributor
erlend-aasland commented Nov 14, 2023
@AlexWaygood, are you fine with the clinic.py changes? |
AlexWaygood approved these changes Nov 14, 2023
Member
AlexWaygood left a comment
AlexWaygood left a comment There was a problem hiding this comment.
This LGTM, sorry for the slow response! I'm not sure I fully understand what the @critical_sectiondoes, but that's more of a documentation question -- this PR looks fine. I'll try to find some time today or tomorrow to comment on the devguide PR you've put up :)
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
python#111904) The `@critical_section` directive instructs Argument Clinic to generate calls to `Py_BEGIN_CRITICAL_SECTION()` and `Py_END_CRITICAL_SECTION()` around the bound function. In `--disable-gil` builds, these calls will lock and unlock the `self` object. They are no-ops in the default build. This is used in one place (`_io._Buffered.close`) as a demonstration. Subsequent PRs will use it more widely in the `_io.Buffered` bindings.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
python#111904) The `@critical_section` directive instructs Argument Clinic to generate calls to `Py_BEGIN_CRITICAL_SECTION()` and `Py_END_CRITICAL_SECTION()` around the bound function. In `--disable-gil` builds, these calls will lock and unlock the `self` object. They are no-ops in the default build. This is used in one place (`_io._Buffered.close`) as a demonstration. Subsequent PRs will use it more widely in the `_io.Buffered` bindings.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
@critical_sectiondirective instructs Argument Clinic to generate calls toPy_BEGIN_CRITICAL_SECTION()andPy_END_CRITICAL_SECTION()around the bound function. In--disable-gilbuilds, these calls will lock and unlock theselfobject. They are no-ops in the default build.This is used in one place (
_io._Buffered.close) as a demonstration. Subsequent PRs will use it more widely in the_io.Bufferedbindings.Py_BEGIN_CRITICAL_SECTION()) #111903