Skip to content

gh-112194: Convert more examples to doctests in typing.py#112195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexWaygood merged 4 commits into from
Nov 17, 2023
Merged

gh-112194: Convert more examples to doctests in typing.py#112195

AlexWaygood merged 4 commits into from
Nov 17, 2023

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Nov 17, 2023•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Nov 17, 2023
Closed
AlexWaygood
AlexWaygood reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, overall I like this. In general I like doctests to look pretty much like actual REPL sessions, though: here that mostly means fewer blank lines

sobolevnand others added 2 commits November 17, 2023 18:23
@sobolevn@AlexWaygood
Apply suggestions from code review
faac9a3
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@AlexWaygood
one more nit
7b835b7
AlexWaygood
AlexWaygood reviewed Nov 17, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Nov 17, 2023
@AlexWaygoodAlexWaygood enabled auto-merge (squash) November 17, 2023 17:43
@AlexWaygoodAlexWaygood merged commit 949b2cc into python:mainNov 17, 2023
@miss-islington-app
Copy link

miss-islington-appbot commented Nov 17, 2023

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2023
@sobolevn@AlexWaygood@miss-islington
pythongh-112194: Convert more examples to doctests intyping.py(py…
9420f2d
…thonGH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2023
@sobolevn@AlexWaygood@miss-islington
pythongh-112194: Convert more examples to doctests intyping.py(py…
6687a9f
…thonGH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-appbot commented Nov 17, 2023

GH-112208 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Nov 17, 2023
@bedevere-app
Copy link

bedevere-appbot commented Nov 17, 2023

GH-112209 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Nov 17, 2023
AlexWaygood added a commit that referenced this pull request Nov 17, 2023
@miss-islington@sobolevn@AlexWaygood
[3.11]gh-112194: Convert more examples to doctests intyping.py(G…
e7aa40a
…H-112195) (#112209) gh-112194: Convert more examples to doctests in `typing.py` (GH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Nov 17, 2023
@miss-islington@sobolevn@AlexWaygood
[3.12]gh-112194: Convert more examples to doctests intyping.py(G…
0ea6454
…H-112195) (#112208) gh-112194: Convert more examples to doctests in `typing.py` (GH-112195) (cherry picked from commit 949b2cc) Co-authored-by: Nikita Sobolev <mail@sobolevn.me> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@sobolevn@AlexWaygood@aisk
pythongh-112194: Convert more examples to doctests intyping.py(py…
82f4cc2
…thon#112195) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@sobolevn@AlexWaygood@Glyphack
pythongh-112194: Convert more examples to doctests intyping.py(py…
7a4faef
…thon#112195) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@JelleZijlstraJelleZijlstraAwaiting requested review from JelleZijlstraJelleZijlstra is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn@AlexWaygood