Skip to content

Conversation

@salty-horse
Copy link
Contributor

@salty-horsesalty-horse commented Nov 17, 2023

The documentation of the deprecation of typing aliases in 3.12 (#94309) was just the names of the aliases, without a description of what happens to them. This can cause confusion, even if it's in the "Deprecated" section of documentation, since all other items include this description.

This should be backported to 3.12.


📚 Documentation preview 📚: https://cpython-previews--112196.org.readthedocs.build/

@bedevere-appbedevere-appbot added awaiting review docs Documentation in the Doc dir skip news labels Nov 17, 2023
@AlexWaygoodAlexWaygood self-requested a review November 17, 2023 10:23
@AlexWaygoodAlexWaygood changed the title gh-94309: Fix documentation for deprecated aliasesgh-94309: py312 "what's new": improve deprecation notice for typing.Hashable and typing.SizedNov 17, 2023
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlexWaygoodAlexWaygood enabled auto-merge (squash) November 17, 2023 12:25
@AlexWaygoodAlexWaygood self-assigned this Nov 17, 2023
@AlexWaygoodAlexWaygood merged commit fb4cddb into python:mainNov 17, 2023
@miss-islington-app
Copy link

Thanks @salty-horse for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 17, 2023
…ce for typing.Hashable and typing.Sized (pythonGH-112196) (cherry picked from commit fb4cddb) Co-authored-by: Ori Avtalion <ori@avtalion.name>
@bedevere-app
Copy link

GH-112200 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Nov 17, 2023
AlexWaygood pushed a commit that referenced this pull request Nov 17, 2023
…ice for typing.Hashable and typing.Sized (GH-112196) (#112200) gh-94309: "What's new in Python 3.12": improve deprecation notice for typing.Hashable and typing.Sized (GH-112196) (cherry picked from commit fb4cddb) Co-authored-by: Ori Avtalion <ori@avtalion.name>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip newstopic-typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@salty-horse@AlexWaygood