gh-110383: Fix documentation profile cumtime fix#112221
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
All commit authors signed the Contributor License Agreement. |
bedevere-appbot added awaiting review docs 
hugovk reviewed Nov 18, 2023
Doc/library/profile.rst Outdated
| 1 0.000 0.000 0.000 0.000 _parser.py:435(_parse_sub) | ||
| The first line indicates that 214 calls were monitored. Of those calls, 207 | ||
| The first line indicates that 214 calls were monitored. Of those calls, 207 |
Member
There was a problem hiding this comment.
Let's not change unrelated whitespace.
Suggested change
| The first line indicates that 214 calls were monitored. Of those calls, 207 | |
| The first line indicates that 214 calls were monitored. Of those calls, 207 |
ContributorAuthor
There was a problem hiding this comment.
Sure, I also thought it was unrelated, just pretty close to context too. Returned
Member
There was a problem hiding this comment.
Thanks. I also prefer one space, but we allow either one or two: https://devguide.python.org/documentation/style-guide/#use-of-whitespace
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added needs backport to 3.11 
Member
hugovk commented Nov 19, 2023
Thank you! |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
(cherry picked from commit 6bf8f20) Co-authored-by: Alex Ptakhin <me@aptakhin.name> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 19, 2023
(cherry picked from commit 6bf8f20) Co-authored-by: Alex Ptakhin <me@aptakhin.name> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
GH-112262 is a backport of this pull request to the 3.12 branch. |
GH-112263 is a backport of this pull request to the 3.11 branch. |
ContributorAuthor
aptakhin commented Nov 19, 2023
Thank you for the help! |
hugovk added a commit that referenced this pull request Nov 19, 2023
hugovk added a commit that referenced this pull request Nov 19, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rephrased for a clearer explanation: profiler docs inaccuracy by 2dfkit
https://mail.python.org/archives/list/docs@python.org/thread/DJNXVVP2UW4R6OAPRA6TE5WMHDC4NKZ6/#DJNXVVP2UW4R6OAPRA6TE5WMHDC4NKZ6
📚 Documentation preview 📚: https://cpython-previews--112221.org.readthedocs.build/