Skip to content

gh-112213: Add @critical_section target directive to Argument Clinic#112232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
corona10 merged 8 commits into from
Nov 18, 2023
Merged

gh-112213: Add @critical_section target directive to Argument Clinic #112232

corona10 merged 8 commits into from
Nov 18, 2023

Conversation

@corona10
Copy link
Member

@corona10corona10 commented Nov 18, 2023•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Nov 18, 2023
Closed
@corona10
Copy link
MemberAuthor

corona10 commented Nov 18, 2023•
edited
Loading

@colesbury Do we have to support Py_BEGIN_CRITICAL_SECTION2 case too? [done]
(I am working on it)

@corona10corona10 changed the title gh-112213: Add @critical_section target directive to Argument Clinic[WIP]gh-112213: Add @critical_section target directive to Argument ClinicNov 18, 2023
@corona10corona10 changed the title [WIP]gh-112213: Add @critical_section target directive to Argument Clinicgh-112213: Add @critical_section target directive to Argument ClinicNov 18, 2023
AlexWaygood
AlexWaygood reviewed Nov 18, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions:

AlexWaygood
AlexWaygood approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Python code LGTM! I'll leave it to the other two to review the generated C code :D

colesbury
colesbury approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@corona10corona10 merged commit e52cc80 into python:mainNov 18, 2023
@corona10corona10 deleted the gh-112213 branch November 19, 2023 03:36
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@corona10@AlexWaygood@aisk
pythongh-112213: Add @critical_section target directive to Argument C…
efe0444
…linic (pythongh-112232) Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@corona10@AlexWaygood@Glyphack
pythongh-112213: Add @critical_section target directive to Argument C…
76860fe
…linic (pythongh-112232) Co-authored-by: Alex Waygood <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesburycolesburycolesbury approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aaslanderlend-aasland is a code owner

Assignees

No one assigned

Labels

skip newstopic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@corona10@colesbury@AlexWaygood