Skip to content

gh-108901: Deprecate inspect.getcallargs and slate it for removal#112236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sobolevn wants to merge 6 commits into
base:main
Choose a base branch
from
Open

gh-108901: Deprecate inspect.getcallargs and slate it for removal #112236

sobolevn wants to merge 6 commits into from

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Nov 18, 2023•
edited by github-actions bot
Loading

Since this function already has a modern alternative and was deprecated since 3.5, I've added a runtime warning for this function and slated it for removal in two versions (3.15) from now.

📚 Documentation preview 📚: https://cpython-previews--112236.org.readthedocs.build/

@bedevere-appbedevere-appbot mentioned this pull request Nov 18, 2023
Open
AlexWaygood
AlexWaygood reviewed Nov 18, 2023
View reviewed changes
terryjreedy
terryjreedy reviewed Nov 18, 2023
View reviewed changes
terryjreedy
terryjreedy reviewed Nov 18, 2023
View reviewed changes
Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the details of code deprecation, but I improved the wording of the public announcements.

@sobolevn
Copy link
MemberAuthor

sobolevn commented Nov 18, 2023

@terryjreedy thank you!

@terryjreedy
Copy link
Member

terryjreedy commented Nov 18, 2023•
edited
Loading

The added code looks sensible but I would want someone more knowledgeable to check and a manual test of the notice.
EDIT: remove mistaken comment, and hide sobolevn's correct response thereto.

@sobolevn

This comment was marked as outdated.

Sign in to view
itamaro
itamaro reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@itamaroitamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phrasing nits in the news and whatnew entries

AlexWaygood
AlexWaygood reviewed Nov 22, 2023
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexWaygood
Copy link
Member

AlexWaygood commented Nov 22, 2023

Ah, I see @hugovk asked for some changes in #108901 (comment) -- I'll hold off merging for now :)

@Wulian233
Copy link
Contributor

Wulian233 commented Apr 26, 2025

I also recently found this issue, which may have been forgotten here, and needs to be removed in the 3.16 if added in 3.14

@vstinner
Copy link
Member

vstinner commented Apr 29, 2025

@sobolevn: What's the status of your PR?

@sobolevn
Copy link
MemberAuthor

sobolevn commented Apr 29, 2025

I guess that I will have to start everything over in 3.15 :)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaroitamaroitamaro left review comments

@terryjreedyterryjreedyterryjreedy left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gpsheadgpsheadAwaiting requested review from gpshead

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sobolevn@terryjreedy@AlexWaygood@Wulian233@vstinner@itamaro