Skip to content

GH-77621: Delay some imports from pathlib#112244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
barneygale merged 3 commits into from
Nov 25, 2023
Merged

GH-77621: Delay some imports from pathlib #112244

barneygale merged 3 commits into from
Nov 25, 2023

Conversation

@barneygale
Copy link
Contributor

@barneygalebarneygale commented Nov 18, 2023•
edited by bedevere-app bot
Loading

Import contextlib, glob and re only as required.

@barneygale
pythonGH-77621: Delay some imports from pathlib
90c3018
Import `contextlib`, `glob` and `re` only as required.
@barneygalebarneygale added performance Performance or resource usage topic-pathlib labels Nov 18, 2023
@bedevere-appbedevere-appbot mentioned this pull request Nov 18, 2023
Closed
@barneygalebarneygale marked this pull request as ready for review November 21, 2023 03:00
AlexWaygood
AlexWaygood reviewed Nov 25, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Nov 25, 2023
View reviewed changes
AlexWaygood
AlexWaygood reviewed Nov 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cuts >50% off the import time for me locally, which is fantastic! Definitely worth doing -- I left some thoughts above about the particulars :)

@barneygale@AlexWaygood
Speed up _compile_pattern()
97f2836
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@barneygale
Copy link
ContributorAuthor

barneygale commented Nov 25, 2023

Thank you very much :)

@barneygalebarneygale enabled auto-merge (squash) November 25, 2023 17:28
@barneygalebarneygale merged commit bbb4367 into python:mainNov 25, 2023
@danielhollasdanielhollas mentioned this pull request Dec 12, 2023
Closed
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale@AlexWaygood@aisk
pythonGH-77621: Delay some imports from pathlib (python#112244)
ab8fe83
Import `contextlib`, `glob` and `re` only as required. Co-authored-by: Alex Waygood <[email protected]>
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale@AlexWaygood@Glyphack
pythonGH-77621: Delay some imports from pathlib (python#112244)
03a4396
Import `contextlib`, `glob` and `re` only as required. Co-authored-by: Alex Waygood <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

performancePerformance or resource usagetopic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@barneygale@AlexWaygood