gh-111903: Update AC to support "pycore_critical_section.h" header#112251
Uh oh!
There was an error while loading. Please reload this page.
Conversation
corona10 requested review from AlexWaygood, erlend-aasland and rhettinger as code owners
corona10 commented Nov 18, 2023
@colesbury IMO, we don't have to declare |
| # include"pycore_gc.h"// PyGC_Head | ||
| # include"pycore_runtime.h"// _Py_ID() | ||
| #endif | ||
| #include"pycore_critical_section.h"// Py_BEGIN_CRITICAL_SECTION() |
There was a problem hiding this comment.
The formatting isn't great here: it would be nice if the generated code had at least one space (preferably two) before each inline comment
There was a problem hiding this comment.
(This can be dealt with in a followup PR, though, if you'd prefer to merge this one quickly :)
There was a problem hiding this comment.
IMO, It will affect the overall generated code formatting since we have to touch
cpython/Tools/clinic/clinic.py
Lines 2347 to 2350 in 1a969b4
So, let's handle it as a separate PR, @AlexWaygood would you like to touch it?
(Easy way might just updating
INCLUDE_COMMENT_COLUMN but there might be smarter policy rather than fixed policy)There was a problem hiding this comment.
Simply updating INCLUDE_COMMENT_COLUMN to 38 will resolve this issue.
But IMO, this value should be adaptively chosen.
There was a problem hiding this comment.
I'll try to find some time in the next few days to look at it, but can't guarantee it right now!
Anyway, I'm happy to defer this for now; it's definitely not the most important thing in the world :)
3 participants
Py_BEGIN_CRITICAL_SECTION()) #111903