Skip to content

Conversation

@tonybaloney
Copy link
Contributor

@tonybaloneytonybaloney commented Nov 30, 2023

@tonybaloney
Copy link
ContributorAuthor

Can be back-ported to Python 3.12

@tonybaloney
Copy link
ContributorAuthor

@ericsnowcurrentlyinterpid type is opaque, is that correct?

Copy link
Contributor

@blaisepblaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change

A interpreter ID identifies a interpreter and may be used as an int. 

to

A interpreter ID identifies a interpreter and may be used as an :class:`int`. 

:c:func:`Py_FinalizeEx` will destroy all sub-interpreters that
haven't been explicitly destroyed at that point.
Interpreter ID Objects
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving this some attention so that we can get it merged soon.
This section looks good so far

Interpreter ID Objects
----------------------
A interpreter ID identifies a interpreter and may be used as an int.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk suggested that you link to the class definition,
changing

A interpreter ID identifies a interpreter and may be used as an int. 

to

A interpreter ID identifies a interpreter and may be used as an :class:`int`. 

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A interpreter ID identifies a interpreter and may be used as an int.
A interpreter ID identifies a interpreter and may be used as an :class:`int`.

Copy link
Contributor

@blaisepblaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(added the change as a markdown suggestion to make it more convenient)

Interpreter ID Objects
----------------------
A interpreter ID identifies a interpreter and may be used as an int.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A interpreter ID identifies a interpreter and may be used as an int.
A interpreter ID identifies a interpreter and may be used as an :class:`int`.

@ericsnowcurrently
Copy link
Member

FYI, I've dropped interpreter ID objects.

@blaisep
Copy link
Contributor

FYI, I've dropped interpreter ID objects.
Are you recommending that we close this PR? (Is is obsolete?)

@ericsnowcurrently
Copy link
Member

I'd need to double-check, but, yeah, we'd probably close this PR.

@blaisep
Copy link
Contributor

I'd need to double-check, but, yeah, we'd probably close this PR.

Thank you @ericsnowcurrently , I will ask @tonybaloney if he will close this PR.

@willingc
Copy link
Contributor

@tonybaloney I'm going to close this PR. If needed we can reopen. Thanks.

@willingcwillingc closed this Nov 4, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

4 participants

@tonybaloney@ericsnowcurrently@blaisep@willingc