Skip to content

Conversation

@AlexWaygood
Copy link
Member

@AlexWaygoodAlexWaygood commented Dec 5, 2023

Many still remain, but this gets rid of 40-or-so warnings


📚 Documentation preview 📚: https://cpython-previews--112737.org.readthedocs.build/

@AlexWaygoodAlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Dec 5, 2023
@bedevere-appbedevere-appbot added docs Documentation in the Doc dir skip news labels Dec 5, 2023
@AlexWaygoodAlexWaygood marked this pull request as ready for review December 5, 2023 01:03
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, but frozenset.add.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexWaygoodAlexWaygood merged commit 2f20caf into python:mainDec 5, 2023
@AlexWaygoodAlexWaygood deleted the datamodel-nitpicks branch December 5, 2023 09:59
@miss-islington-app
Copy link

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2023
…model docs (pythonGH-112737) (cherry picked from commit 2f20caf) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

GH-112748 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Dec 5, 2023
@bedevere-app
Copy link

GH-112749 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 5, 2023
…model docs (pythonGH-112737) (cherry picked from commit 2f20caf) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Dec 5, 2023
AlexWaygood added a commit that referenced this pull request Dec 5, 2023
…amodel docs (GH-112737) (#112748) gh-101100: Fix many easily solvable Sphinx nitpicks in the datamodel docs (GH-112737) (cherry picked from commit 2f20caf) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood added a commit that referenced this pull request Dec 5, 2023
…amodel docs (GH-112737) (#112749) gh-101100: Fix many easily solvable Sphinx nitpicks in the datamodel docs (GH-112737) (cherry picked from commit 2f20caf) Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@AlexWaygood@serhiy-storchaka