Skip to content

GH-111485: Factor out tier 2 code generation from the rest of the interpreter code generator#112968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 9 commits into from
Dec 12, 2023
Merged

GH-111485: Factor out tier 2 code generation from the rest of the interpreter code generator #112968

markshannon merged 9 commits into from
Dec 12, 2023

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Dec 11, 2023•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Dec 11, 2023
Closed
iritkatriel
iritkatriel reviewed Dec 11, 2023
View reviewed changes
gvanrossum
gvanrossum reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits. Please also use black on all files you touched.

Tools/cases_generator/tier1_generator.py
out.emit(f"{type}{var.name};\n")


defemit_to(out: CWriter, tkn_iter: Iterator[Token], end: str) ->None:
Copy link
Member

@gvanrossumgvanrossumDec 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make any changes to the code that you moved to generators_common.py or stack.py? Or is it strictly a move?

Copy link
MemberAuthor

@markshannonmarkshannonDec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is strictly a move

Tools/cases_generator/generators_common.py
)


defemit_to(out: CWriter, tkn_iter: Iterator[Token], end: str) ->None:
Copy link
Member

@gvanrossumgvanrossumDec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a method on CWriter.

Copy link
MemberAuthor

@markshannonmarkshannonDec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but it tracks the parentheses in the tkn_iter input, which seems out of scope for a writer.

@markshannonmarkshannon merged commit 0c55f27 into python:mainDec 12, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@markshannon@aisk
pythonGH-111485: Factor out tier 2 code generation from the rest of t…
cd18c36
…he interpreter code generator (pythonGH-112968)
@markshannonmarkshannon deleted the tier-2-code-gen branch August 6, 2024 10:18
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@markshannon@Glyphack
pythonGH-111485: Factor out tier 2 code generation from the rest of t…
348f9c0
…he interpreter code generator (pythonGH-112968)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum left review comments

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@iritkatriel@gvanrossum