Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-113299: Create libclinic package#113309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| from __future__ import annotations | ||
| import dataclasses as dc | ||
| from typing import ( | ||
| Literal, | ||
| NoReturn, | ||
| overload, | ||
| TYPE_CHECKING, | ||
| ) | ||
| if TYPE_CHECKING: | ||
| from clinic import Clinic | ||
| # Clinic instance | ||
| clinic: 'Clinic' | None = None | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This PR feels like it only does my least favourite thing about your other PR :// #113299 (comment) | ||
| @dc.dataclass | ||
| class ClinicError(Exception): | ||
| message: str | ||
| _: dc.KW_ONLY | ||
| lineno: int | None = None | ||
| filename: str | None = None | ||
| def __post_init__(self) -> None: | ||
| super().__init__(self.message) | ||
| def report(self, *, warn_only: bool = False) -> str: | ||
| msg = "Warning" if warn_only else "Error" | ||
| if self.filename is not None: | ||
| msg += f" in file{self.filename!r}" | ||
| if self.lineno is not None: | ||
| msg += f" on line{self.lineno}" | ||
| msg += ":\n" | ||
| msg += f"{self.message}\n" | ||
| return msg | ||
| @overload | ||
| def warn_or_fail( | ||
| *args: object, | ||
| fail: Literal[True], | ||
| filename: str | None = None, | ||
| line_number: int | None = None, | ||
| ) -> NoReturn: ... | ||
| @overload | ||
| def warn_or_fail( | ||
| *args: object, | ||
| fail: Literal[False] = False, | ||
| filename: str | None = None, | ||
| line_number: int | None = None, | ||
| ) -> None: ... | ||
| def warn_or_fail( | ||
| *args: object, | ||
| fail: bool = False, | ||
| filename: str | None = None, | ||
| line_number: int | None = None, | ||
| ) -> None: | ||
| joined = " ".join([str(a) for a in args]) | ||
| if clinic: | ||
| if filename is None: | ||
| filename = clinic.filename | ||
| if getattr(clinic, 'block_parser', None) and (line_number is None): | ||
| line_number = clinic.block_parser.line_number | ||
| error = ClinicError(joined, filename=filename, lineno=line_number) | ||
| if fail: | ||
| raise error | ||
| else: | ||
| print(error.report(warn_only=True)) | ||
| def warn( | ||
| *args: object, | ||
| filename: str | None = None, | ||
| line_number: int | None = None, | ||
| ) -> None: | ||
| return warn_or_fail(*args, filename=filename, line_number=line_number, fail=False) | ||
| def fail( | ||
| *args: object, | ||
| filename: str | None = None, | ||
| line_number: int | None = None, | ||
| ) -> NoReturn: | ||
| warn_or_fail(*args, filename=filename, line_number=line_number, fail=True) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, putting a global from one file into another file is not a good idea.