Skip to content

GH-111485: Fix handling of FOR_ITER in tier2#113394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 1 commit into from
Dec 24, 2023
Merged

GH-111485: Fix handling of FOR_ITER in tier2 #113394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions Python/optimizer.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -518,11 +518,11 @@ translate_bytecode_to_trace(

uint32_t opcode = instr->op.code;
uint32_t oparg = instr->op.arg;
uint32_t extras = 0;
uint32_t extended = 0;

if (opcode == EXTENDED_ARG){
instr++;
extras += 1;
extended = 1;
opcode = instr->op.code;
oparg = (oparg << 8) | instr->op.arg;
if (opcode == EXTENDED_ARG){
Expand DownExpand Up@@ -577,6 +577,7 @@ translate_bytecode_to_trace(
}

case JUMP_BACKWARD:
case JUMP_BACKWARD_NO_INTERRUPT:
{
if (instr + 2 - oparg == initial_instr && code == initial_code){
RESERVE(1);
Expand DownExpand Up@@ -623,15 +624,7 @@ translate_bytecode_to_trace(
int offset = expansion->uops[i].offset + 1;
switch (expansion->uops[i].size){
case OPARG_FULL:
if (extras && OPCODE_HAS_JUMP(opcode)){
if (opcode == JUMP_BACKWARD_NO_INTERRUPT){
oparg -= extras;
}
else{
assert(opcode != JUMP_BACKWARD);
oparg += extras;
}
}
assert(opcode != JUMP_BACKWARD_NO_INTERRUPT && opcode != JUMP_BACKWARD);
break;
case OPARG_CACHE_1:
operand = read_u16(&instr[offset].cache);
Expand All@@ -656,7 +649,7 @@ translate_bytecode_to_trace(
uop = _PyUOp_Replacements[uop];
assert(uop != 0);
if (uop == _FOR_ITER_TIER_TWO){
target += 1 + INLINE_CACHE_ENTRIES_FOR_ITER + oparg + 1;
target += 1 + INLINE_CACHE_ENTRIES_FOR_ITER + oparg + 1 + extended;
assert(_PyCode_CODE(code)[target-1].op.code == END_FOR ||
_PyCode_CODE(code)[target-1].op.code == INSTRUMENTED_END_FOR);
}
Expand Down