Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
gh-112532: Fix peg generator build.py for mimalloc build#113492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
corona10 commented Dec 26, 2023 • edited by bedevere-app bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by bedevere-app bot
Uh oh!
There was an error while loading. Please reload this page.
corona10 commented Dec 26, 2023
AS-ISTO-BE |
bedevere-bot commented Dec 26, 2023
pablogsal left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we can do this unconditionally on the mimalloc build no?
corona10 commented Dec 26, 2023
Or we can use |
pablogsal commented Dec 26, 2023
Nah is fine, just wanted to ensure that the header include is correct independently if we have mimalloc or not |
colesbury left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this.
Yeah, I think the include path is fine even if we are not compiling with mimalloc support.
corona10 commented Dec 26, 2023 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
We always include Lines 1795 to 1800 in acf3bcc
|
…ngh-113492) pythongh-112532: Fix peg generator for mimalloc build
…ngh-113492) pythongh-112532: Fix peg generator for mimalloc build
…ngh-113492) pythongh-112532: Fix peg generator for mimalloc build
--disable-gilbuilds #112532