Skip to content

Conversation

@hugovk
Copy link
Member

@hugovkhugovk commented Dec 26, 2023

Fix these five warnings:

  • the first by documenting it
  • the next two each refer to methods of two subclasses, so it's not obvious which subclass (or superclass)'s methods to link to, so just silence with !
  • the last two by including the relevant class in the link
Doc/library/calendar.rst:232: WARNING: py:meth reference target not found: formatmonthname Doc/library/calendar.rst:292: WARNING: py:meth reference target not found: formatweekday Doc/library/calendar.rst:292: WARNING: py:meth reference target not found: formatmonthname Doc/library/calendar.rst:361: WARNING: py:meth reference target not found: formatmonth Doc/library/calendar.rst:372: WARNING: py:meth reference target not found: formatyear 

📚 Documentation preview 📚: https://cpython-previews--113500.org.readthedocs.build/

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hugovkhugovk enabled auto-merge (squash) December 27, 2023 09:28
@hugovkhugovk merged commit fb02b66 into python:mainDec 27, 2023
@hugovkhugovk deleted the docs-fix-sphinx-warnings-calendar branch December 27, 2023 09:36
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fb02b6696002fc3dedbcf7c58aa40301650936ba 3.12 

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 27, 2023
…nGH-113500) (cherry picked from commit fb02b66) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-113508 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Dec 27, 2023
@bedevere-app
Copy link

GH-113509 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Dec 27, 2023
hugovk added a commit to hugovk/cpython that referenced this pull request Dec 27, 2023
…pythonGH-113500) (cherry picked from commit fb02b66) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull request Dec 27, 2023
…13500) (#113508) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk@serhiy-storchaka