bpo-35214: Skip test_io tests that'd cause a huge malloc under msan#11385
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
miss-islington commented Dec 31, 2018
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
bedevere-bot commented Dec 31, 2018
@gpshead: Please replace |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 31, 2018
…ythonGH-11385) * skip test_constructor under msan. * fix the others as well. * reuse existing related news entry. * typo fix (cherry picked from commit e5796c4) Co-authored-by: Gregory P. Smith <greg@krypto.org>
bedevere-bot commented Dec 31, 2018
GH-11388 is a backport of this pull request to the 3.7 branch. |
miss-islington added a commit that referenced this pull request Dec 31, 2018
csabella pushed a commit to csabella/cpython that referenced this pull request Dec 31, 2018
…ython#11385) * skip test_constructor under msan. * fix the others as well. * reuse existing related news entry. * typo fix
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clang memory sanitizers default behavior is to crash when a malloc that cannot succeed is called rather than returning an error. Lets just skip these tests under msan; not much value there.
https://bugs.python.org/issue35214