Skip to content

Conversation

@lazorchakp
Copy link
Contributor

@lazorchakplazorchakp commented Jan 17, 2024

Backports #113558 to 3.12. Also backports #113953, which fixes a bug in the original PR.

  • I removed two test cases from test_type_cache for specializations that only exist on main
  • I also need to backport this to 3.11, but that is currently proving to be a bit more complicated than I would have hoped

@lazorchakplazorchakp marked this pull request as ready for review January 17, 2024 23:39
@lazorchakp
Copy link
ContributorAuthor

@Fidget-Spinner keeping you in the loop for this. I'm still working on the 3.11 backport

@lazorchakplazorchakp changed the title [3.12] Check for valid tp_version_tag in specializer (gh-89811)[3.12] Check for valid tp_version_tag in specializer (gh-113558, gh-113953)Jan 17, 2024
@lazorchakplazorchakp changed the title [3.12] Check for valid tp_version_tag in specializer (gh-113558, gh-113953)[3.12] Check for valid tp_version_tag in specializer (gh-89811)Jan 17, 2024
@Fidget-SpinnerFidget-Spinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 18, 2024
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 321137e 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 18, 2024
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These buildbots fail on main too, so this PR should be fine. Thanks!

@Fidget-SpinnerFidget-Spinner merged commit ae2a25b into python:3.12Jan 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lazorchakp@bedevere-bot@Fidget-Spinner