gh-113655: Revert extra stack reserve in PGO builds unless UseExtraStackReserve=true#114263
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…xtraStackReserve=true
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…xtraStackReserve=true (pythonGH-114263)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…xtraStackReserve=true (pythonGH-114263)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to avoid expanding the default memory allocation for every Python stack, so changing the default back to the original value to encourage a real fix.
The option is there to avoid this becoming a release blocking issue next release.