Skip to content

gh-79856: IDLE - separate config_key window and frame#11427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 2 commits into from
Sep 30, 2022
Merged

gh-79856: IDLE - separate config_key window and frame #11427

terryjreedy merged 2 commits into from
Sep 30, 2022

Conversation

@csabella
Copy link
Contributor

@csabellacsabella commented Jan 3, 2019•
edited by terryjreedy
Loading

Split dialog class into a Window class and Frame class and adjust tests to match.

@terryjreedyterryjreedy changed the title bpo-35598: IDLE: Refactor configkey.py window and frame classbpo-35675: IDLE config_key - separate window and frame classesJan 7, 2019
auvipy
auvipy suggested changes Jun 2, 2019
View reviewed changes
Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase

iritkatriel
iritkatriel previously requested changes Sep 30, 2022
View reviewed changes
Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased.

@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2022

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatrieliritkatriel added the pending The issue will be closed if no feedback is provided label Sep 30, 2022
@terryjreedyterryjreedy changed the title bpo-35675: IDLE config_key - separate window and frame classesbpo-35675: IDLE config_key - separate window and frameSep 30, 2022
@terryjreedyterryjreedy removed awaiting changes pending The issue will be closed if no feedback is provided labels Sep 30, 2022
@terryjreedyterryjreedy self-assigned this Sep 30, 2022
@terryjreedyterryjreedy changed the title bpo-35675: IDLE config_key - separate window and framebpo-35675: IDLE - separate config_key window and frameSep 30, 2022
@terryjreedyterryjreedy merged commit 1cc308d into python:mainSep 30, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Sep 30, 2022

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Sep 30, 2022
@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2022

GH-97683 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Sep 30, 2022
@bedevere-bot
Copy link

bedevere-bot commented Sep 30, 2022

GH-97684 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@csabella@miss-islington
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
d28ac0d
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 1cc308d) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@csabella@miss-islington
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
e14c481
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 1cc308d) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington@csabella
bpo-35675: IDLE - separate config_key window and frame (GH-11427)
ab2f1a6
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 1cc308d) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington@csabella
bpo-35675: IDLE - separate config_key window and frame (GH-11427)
b61a51a
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu> (cherry picked from commit 1cc308d) Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@terryjreedyterryjreedy changed the title bpo-35675: IDLE - separate config_key window and framegh-79856: IDLE - separate config_key window and frameSep 30, 2022
@terryjreedyterryjreedy mentioned this pull request Sep 30, 2022
Closed
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
@csabella@terryjreedy@serhiy-storchaka
bpo-35675: IDLE - separate config_key window and frame (python#11427)
8fd0e86
bpo-35598: IDLE: Refactor window and frame class Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
mpage added a commit to mpage/cpython that referenced this pull request Feb 16, 2024
@mpage
Merge branch 'pythongh-114271-_thread-ThreadHandle' intopythongh-11427…
012ea77
…-cherry-pick-ThreadHandle
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatrieliritkatrieliritkatriel left review comments

@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy is a code owner

+1 more reviewer

@auvipyauvipyauvipy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@terryjreedyterryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@csabella@bedevere-bot@miss-islington@iritkatriel@auvipy@the-knights-who-say-ni@terryjreedy@ezio-melotti