gh-113317: Don't use global clinic instance in bad_argument()#114330
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Make it possible for a converter to have multiple includes, make the 'includes' an instance attribute. This implies converter includes are added during template generation, so we have to add them to the clinic instance at the end of the template generation instead of in the beginning.
ContributorAuthor
erlend-aasland commented Jan 19, 2024
Competing PR to #114324 😎⚔️ |
ContributorAuthor
erlend-aasland commented Jan 19, 2024
Post this, the global clinic instance is only used by warn/fail. Poke, poke Argument-Clinic#35. |
Uh oh!
There was an error while loading. Please reload this page.
vstinner approved these changes Jan 22, 2024
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
erlend-aasland commented Jan 22, 2024
Thanks for the review, Victor. I'll wait a bit for Alex to chime in before landing. |
ContributorAuthor
erlend-aasland commented Jan 23, 2024
I'm going to land this tomorrow. |
AlexWaygood approved these changes Jan 23, 2024
Member
AlexWaygood left a comment
AlexWaygood left a comment There was a problem hiding this comment.
Nice, thanks! Sorry for the delay!
ContributorAuthor
erlend-aasland commented Jan 23, 2024
Thanks, both! |
Member
vstinner commented Jan 23, 2024
One less usage of globals! |
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
…ython#114330) Make it possible for a converter to have multiple includes, by collecting them in a list on the converter instance. This implies converter includes are added during template generation, so we have to add them to the clinic instance at the end of the template generation instead of in the beginning.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
…ython#114330) Make it possible for a converter to have multiple includes, by collecting them in a list on the converter instance. This implies converter includes are added during template generation, so we have to add them to the clinic instance at the end of the template generation instead of in the beginning.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible for a converter to have multiple includes.
Also make the 'includes' an instance attribute. This implies
some converter includes are added to the converters during
template generation (parse_arg()), so we have to query the
converters about their includes at the end of the template
generation.