Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 34k
Improvements in regular expression doc#114357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adorilson wants to merge 34 commits into python:mainChoose a base branch from adorilson:re_improvements
base:main
Could not load branches
Branch not found: {{refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading. Please reload this page.
Open
Changes from all commits
Commits
Show all changes
34 commits Select commit Hold shift + click to select a range
817b3f3 Doc: Fix the array.fromfile method doc
adorilson 6b53456 gh-106320: Remove private _PyInterpreterState functions (#106335)
vstinner 1b4d152 [Doc] Divide RE Syntax in subsections
adorilson 6ad009c [DOC] Add crasis surrounding some RE-matched words
adorilson 94f765f [DOC] Make clearer what will be matched with a RE
adorilson 292672b Doc: minor change
adorilson 65b4278 Merge branch 'python:main' into re_improvements
adorilson fe7389a Merge branch 'python:main' into re_improvements
adorilson 8394cd3 Merge branch 'python:main' into re_improvements
adorilson e2023e0 Doc: Put PatternError's attributes inside a table instead of regular …
adorilson cdaa9ae Doc: Fix PatternError's attributes
adorilson bb98dad Doc: fix lint issue
adorilson 22ffed7 Merge branch 'main' into re_improvements
adorilson 6a1e74e Merge branch 'python:main' into re_improvements
adorilson 6b357af Doc: Add extension notation header
adorilson 8f7356d Doc: Add some more backticks
adorilson 6ed5109 Merge branch 'python:main' into re_improvements
adorilson 9c17aa8 Doc: Fix malformed hyperlink target
adorilson acb2e38 Merge branch 'main' into re_improvements
adorilson 4d3b8dd Merge branch 'python:main' into re_improvements
adorilson 643070c Merge branch 'main' into re_improvements
adorilson 17baf98 Docs: add a 'also' for $ special character and RE examples reference …
adorilson 4e12f7c Docs: add some RE raw string notation references
adorilson a09a187 Merge branch 'python:main' into re_improvements
adorilson 625a5cf Revert "[DOC] Make clearer what will be matched with a RE"
adorilson 12ecb3a Doc: Put some subheadings at Special Character section
adorilson f576282 Doc: Fix raw string notation reference
adorilson 337e4b4 Merge branch 'python:main' into re_improvements
adorilson 0e0e082 Doc: Include "Python's" to a link text in RE module
adorilson f094a90 Doc: Add some backticks in re.IGNORECASE section
adorilson fd24e0f Merge branch 'main' into re_improvements
adorilson a8c44e1 Merge branch 'main' into re_improvements
adorilson f970235 Doc: rename some heading in RE
adorilson 8d52469 Doc: Connect some s in RE
adorilson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the original was easier to read, with the full string being searched given in a different font from the substrings that are found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, it was inconsistent with the "(In the rest of this section, we’ll write RE’s in this special style, usually without quotes, and strings to be matched 'in single quotes'.)"
However, you highlighted that 'strings to be matched' is different from 'the matches'. On the other hand, both are literal strings, and this is a common pattern around all docs.
I would like some more opinions here.