gh-108303: Move smtpd to test.support#114368
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sobolevn added skip news needs backport to 3.11 
AlexWaygood changed the title stmpd to test.supportsmtpd to test.support
vsajip approved these changes Jan 21, 2024
Member
vstinner commented Jan 22, 2024
This change should not be backported to 3.11: it was done in Python 3.12. |
vstinner approved these changes Jan 22, 2024
| fromsocketserverimport (ThreadingUDPServer, DatagramRequestHandler, | ||
| ThreadingTCPServer, StreamRequestHandler) | ||
| withwarnings.catch_warnings(): |
Member
There was a problem hiding this comment.
The change removes with warnings.catch_warnings(): but apparently, it's useless. The test still pass without it:
$ ./python -Werror -m test test_logging test_smtplib -j0 Using random seed: 1598323201 0:00:00 load avg: 0.96 Run 2 tests in parallel using 2 worker processes 0:00:02 load avg: 1.37 [1/2] test_smtplib passed 0:00:18 load avg: 1.22 [2/2] test_logging passed == Tests result: SUCCESS == All 2 tests OK. Total duration: 18.9 sec Total tests: run=317 skipped=2 Total test files: run=2/2 Result: SUCCESS 
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2024
Update test_logging.py and test_smtplib.py. (cherry picked from commit 8f5e7d7) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
GH-114427 is a backport of this pull request to the 3.12 branch. |
Member
vstinner commented Jan 22, 2024
Merged, thanks. |
vstinner pushed a commit that referenced this pull request Jan 22, 2024
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Update test_logging.py and test_smtplib.py.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Update test_logging.py and test_smtplib.py.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module was removed from stdlib in #93246
But, since it is not really a test file, it should have been moved to
Lib/test/support, notLib/test. This PR fixes that :)Now this is in line with
asyncoreandasynchat.