gh-101100: Fix Sphinx warnings in whatsnew/3.11.rst and related#114531
Uh oh!
There was an error while loading. Please reload this page.
Conversation
bedevere-appbot added awaiting core review docs 
hugovk changed the title whatsnew/3.11.rst and relatedwhatsnew/3.11.rst and relatedhugovk added needs backport to 3.11 
serhiy-storchaka left a comment
serhiy-storchaka left a comment There was a problem hiding this comment.
It LGTM for main, but most of the changes should not be backported to 3.11, and some should not be backported to 3.12 either.
It is safer to not use automation, but re-do this work for 3.12 and 3..11 separately, to be sure that you do not remove a working reference.
Doc/whatsnew/3.11.rst Outdated
| * Resizing lists is streamlined for the common case, | ||
| speeding up :meth:`list.append` by ≈15% | ||
| speeding up :meth:`!list.append` by ≈15% |
There was a problem hiding this comment.
I would left it as a reminder that we should add a reference to list.append, and not sweep it under cover.
| ----------- | ||
| * :opcode:`ASYNC_GEN_WRAP`, :opcode:`RETURN_GENERATOR` and :opcode:`SEND`, | ||
| * :opcode:`!ASYNC_GEN_WRAP`, :opcode:`RETURN_GENERATOR` and :opcode:`SEND`, |
There was a problem hiding this comment.
It should not be backported to 3.11.
| * :func:`!importlib.resources.contents` | ||
| * :func:`!importlib.resources.is_resource` | ||
| * :func:`!importlib.resources.open_binary` | ||
| * :func:`!importlib.resources.open_text` | ||
| * :func:`!importlib.resources.read_binary` | ||
| * :func:`!importlib.resources.read_text` | ||
| * :func:`!importlib.resources.path` |
There was a problem hiding this comment.
It should not be backported to 3.12.
serhiy-storchaka removed needs backport to 3.11 
serhiy-storchaka commented Jan 26, 2024
It could be perhaps simpler to make a patch for 3.11, then apply it to 3.12, fix new warnings, apply the new patch to main and fix the remaining warnings. It is how we did before Git. You can still use this sequence for fixing What's New for older versions. |
hugovk commented Jan 26, 2024
yep, good idea.
Interesting, will try that for the next What's New. 👍 |
hugovk commented Jan 27, 2024
Sure, we-added For that PR, https://docs.python.org/3/library/stdtypes.html#mutable-sequence-types Should we link Or add Or somewhere else? |
GH-114649 is a backport of this pull request to the 3.12 branch. |
GH-114650 is a backport of this pull request to the 3.11 branch. |
2 participants
Fix 51 warnings, mainly removals or renames.
📚 Documentation preview 📚: https://cpython-previews--114531.org.readthedocs.build/