Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-101100: Fix datetime reference warnings#114661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
smontanaro commented Jan 27, 2024 • edited by github-actions bot
Loading Uh oh!
There was an error while loading. Please reload this page.
edited by github-actions bot
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
smontanaro commented Jan 28, 2024
@serhiy-storchaka I applied your suggestions, then got a bit carried away. It seems to me that if :attr: with to suppress the link to the documentation the user is currently viewing. If there's a good reason to retain these links, let me know and I'll undo that part of the change. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
smontanaro commented Jan 28, 2024
I've responded to all recent comments. |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka commented Jan 29, 2024
Many references |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 😌
smontanaro commented Jan 29, 2024
Thanks. Feel free to merge. (I don't have -- or want -- check-in privilege.) |
Thanks @smontanaro for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
(cherry picked from commit e8b8f5e) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sorry, @smontanaro and @serhiy-storchaka, I could not cleanly backport this to |
GH-114716 is a backport of this pull request to the 3.12 branch. |
serhiy-storchaka commented Jan 29, 2024
Thank you @smontanaro. It was a complicated issue. The documentation can still be refined: there are paragraphs with repeated links. But this is a different issue. |
serhiy-storchaka commented Jan 29, 2024
Please look also at #114717. |
) (cherry picked from commit e8b8f5e) Co-authored-by: Skip Montanaro <skip.montanaro@gmail.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-114718 is a backport of this pull request to the 3.11 branch. |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Fixed dangling references.
datetime,date, andtimeclasses have many method names in common (not too surprising). Where it didn't seem to make a difference, I changed the reference to thedatetimeversion of the method.📚 Documentation preview 📚: https://cpython-previews--114661.org.readthedocs.build/