Skip to content

Conversation

@sobolevn
Copy link
Member

@sobolevnsobolevn commented Jan 29, 2024

Before:

/Users/sobolev/Desktop/cpython2/Doc/library/enum.rst:798: WARNING: py:attr reference target not found: Enum._name_ /Users/sobolev/Desktop/cpython2/Doc/library/enum.rst:799: WARNING: py:attr reference target not found: Enum._value_ /Users/sobolev/Desktop/cpython2/Doc/library/enum.rst:805: WARNING: py:attr reference target not found: Enum._order_ 

It renders just fine:
Снимок экрана 2024-01-29 в 09 34 09

I though that I can possibly define these attributes in-place, but their rendering would be very strange this way. So, I went with a little duplication.


📚 Documentation preview 📚: https://cpython-previews--114696.org.readthedocs.build/

@hugovk
Copy link
Member

Technically looks okay, but let's check with @ethanfurman: if the whole point of _order_ is for Python 2/3 consistency, do we need to keep that detail in the docs?

Copy link
Member

@ethanfurmanethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor change, then good to go!

@bedevere-app
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@hugovkhugovk merged commit 553c90c into python:mainFeb 9, 2024
@miss-islington-app
Copy link

Thanks @sobolevn for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 553c90ccc2f5b15be76a2bb6e38d23e58d739e2f 3.12 

@miss-islington-app
Copy link

Sorry, @sobolevn and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 553c90ccc2f5b15be76a2bb6e38d23e58d739e2f 3.11 

@sobolevn
Copy link
MemberAuthor

I will send backports PRs later 👍

@bedevere-app
Copy link

GH-115208 is a backport of this pull request to the 3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12 only security fixes label Feb 9, 2024
sobolevn added a commit to sobolevn/cpython that referenced this pull request Feb 9, 2024
@bedevere-app
Copy link

GH-115209 is a backport of this pull request to the 3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11 only security fixes label Feb 9, 2024
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsDocumentation in the Doc dirskip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn@hugovk@ethanfurman