Skip to content

gh-114685: Check flags in PyObject_GetBuffer()#114707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 1 commit into from
Jan 31, 2024
Merged

gh-114685: Check flags in PyObject_GetBuffer() #114707

serhiy-storchaka merged 1 commit into from
Jan 31, 2024

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchakaserhiy-storchaka commented Jan 29, 2024•
edited by bedevere-app bot
Loading

PyObject_GetBuffer() now raises a SystemError if called with PyBUF_READ or PyBUF_WRITE as flags. These flags should only be used with the PyMemoryView_* C API.

@serhiy-storchaka
pythongh-114685: Check flags in PyObject_GetBuffer()
86998f2
PyObject_GetBuffer() now raises a SystemError if called with PyBUF_READ or PyBUF_WRITE as flags. These flags should only be used with the PyMemoryView_* C API.
@bedevere-appbedevere-appbot mentioned this pull request Jan 29, 2024
Closed
sobolevn
sobolevn approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@serhiy-storchakaserhiy-storchaka merged commit b7688ef into python:mainJan 31, 2024
@serhiy-storchakaserhiy-storchaka deleted the buffer-invalid-flags branch January 31, 2024 11:11
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka@aisk
pythongh-114685: Check flags in PyObject_GetBuffer() (pythonGH-114707)
2fcbcf0
PyObject_GetBuffer() now raises a SystemError if called with PyBUF_READ or PyBUF_WRITE as flags. These flags should only be used with the PyMemoryView_* C API.
@ionenwksionenwks mentioned this pull request May 13, 2024
Closed
@hroncokhroncok mentioned this pull request May 29, 2024
Closed
hroncok added a commit to hroncok/pycairo that referenced this pull request May 29, 2024
@hroncok
Avoid invalid PyBUF_READ flag in PyObject_GetBuffer()
387e27f
 Since Python 3.13, the flag is no longer allowed. See python/cpython#114707Fixespygobject#365
@hroncokhroncok mentioned this pull request May 29, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

Assignees

No one assigned

Labels

topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka@sobolevn