Skip to content

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Jan 30, 2024

  • Add Clinic.warn() and Clinic.fail() methods.
  • Add filename parameter to BlockParser constructor.
  • Add BlockParser.fail() method.
  • Add DSLParser.fail() method.
  • Pass lineno parameter to DSLParser.format_docstring(): more accurate error reporting.
  • Convert a few DSLParser static methods to regular method to be able to call self.fail().
  • Language.render() clinic parameter is now required: None is no longer accepted.
  • Remove warn() function.
  • Remove global variable 'clinic'.

fail() and warn() methods get filename and line number from the instance on which the method is called, rather than relying on a global variable 'clinic'.

* Add Clinic.warn() and Clinic.fail() methods. * Add filename parameter to BlockParser constructor. * Add BlockParser.fail() method. * Add DSLParser.fail() method. * Pass lineno parameter to DSLParser.format_docstring(): more accurate error reporting. * Convert a few DSLParser static methods to regular method to be able to call self.fail(). * Language.render() clinic parameter is now required: None is no longer accepted. * Remove warn() function. * Remove global variable 'clinic'. fail() and warn() methods get filename and line number from the instance on which the method is called, rather than relying on a global variable 'clinic'.
@vstinner
Copy link
MemberAuthor

@erlend-aasland@AlexWaygood: Would you mind to review this change?

@erlend-aasland wrote a different approach: Argument-Clinic#35

@vstinner
Copy link
MemberAuthor

See also Argument-Clinic#36

@AlexWaygood
Copy link
Member

I'm stepping down as an AC maintainer for now :) #114796

I trust you two to come to the right decision!

@AlexWaygoodAlexWaygood removed their request for review January 31, 2024 11:40
@vstinner
Copy link
MemberAuthor

I'm stepping down as an AC maintainer for now :) #114796

Even if you're not officially an "expert" or "code owner", your opinion still matters for me, and you're free to pick some reviews whenever you want. But I understand that I should ping you less often on such AC changes ;-)

@vstinner
Copy link
MemberAuthor

Ping @erlend-aasland: Gentle reminder that I'm looking for a review :-)

@erlend-aasland
Copy link
Contributor

Superseded by #115517.

@vstinnervstinner deleted the ac_location branch January 14, 2025 08:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner@AlexWaygood@erlend-aasland