Skip to content

gh-113317, Argument Clinic: Add Clinic.fail() method#115371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vstinner wants to merge 3 commits into from
Closed

gh-113317, Argument Clinic: Add Clinic.fail() method #115371

vstinner wants to merge 3 commits into from

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commented Feb 12, 2024•
edited by bedevere-app bot
Loading

  • Add Clinic.fail() and Clinic.warn() methods.
  • Language.render(): clinic argument is now mandatory (fix type hint).
  • Replace some fail() and warn() calls with Clinic.fail() and Clinic.warn().

@vstinner
pythongh-113317, Argument Clinic: Add Clinic.fail() method
5b14469
* Add Clinic.fail() and Clinic.warn() methods. * Language.render(): clinic argument is now mandatory (fix type hint). * Replace some fail() and warn() calls with Clinic.fail() and Clinic.warn().
@bedevere-appbedevere-appbot mentioned this pull request Feb 12, 2024
Closed
erlend-aasland
erlend-aasland reviewed Feb 14, 2024
View reviewed changes
erlend-aasland
erlend-aasland reviewed Feb 14, 2024
View reviewed changes
vstinnerand others added 2 commits February 14, 2024 22:59
@vstinner@erlend-aasland
Update Tools/clinic/clinic.py
fa9bc96
Co-authored-by: Erlend E. Aasland <[email protected]>
@vstinner@erlend-aasland
Update Tools/clinic/clinic.py
185f284
Co-authored-by: Erlend E. Aasland <[email protected]>
@vstinner
Copy link
MemberAuthor

vstinner commented Feb 14, 2024

Does not this work?

This PR comes from my other PR which removes fail(). But let's move step by step, you're right.

@erlend-aaslanderlend-aasland mentioned this pull request Feb 15, 2024
Merged
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 15, 2024

Obsoleted by #115510

@vstinnervstinner deleted the ac_clinic branch February 15, 2024 14:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

Assignees

No one assigned

Labels

awaiting core reviewskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner@erlend-aasland