Skip to content

Conversation

@ambv
Copy link
Contributor

@ambvambv commented Feb 13, 2024

Pin theme to fix code snippets
(cherry picked from commit 3fcea41)

…-115351) Pin theme to fix code snippets (cherry picked from commit 3fcea41) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built locally:

image

@ambv
Copy link
ContributorAuthor

ambv commented Feb 13, 2024

@hugovk I appreciate it but this was about the dark theme, no?

@hugovk
Copy link
Member

Yes, we're pinning to the last version before the dark theme was added.

This the minimal fix, because the dark theme requires Sphinx 3 for proper syntax highlighting, and the 3.8/3.9 docs use Sphinx 2.4.4.

We can look into bumping Sphinx to 3+, but it will likely also require bumping other dependencies, and for security branches I felt it would be easier/safer to pin to an older python-docs-theme.

@ambv
Copy link
ContributorAuthor

ambv commented Feb 13, 2024

Ah, got it. Right. Okay then, let's go.

@ambvambv merged commit a21c0c7 into python:3.8Feb 13, 2024
@ambvambv deleted the backport-3fcea41-3.8 branch February 13, 2024 13:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ambv@hugovk