Skip to content

gh-113317: Argument Clinic: move C/Py identifier helpers into libclinic#115520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 2 commits into from
Feb 16, 2024
Merged

gh-113317: Argument Clinic: move C/Py identifier helpers into libclinic #115520

erlend-aasland merged 2 commits into from
Feb 16, 2024

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Feb 15, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Feb 15, 2024
Closed
erlend-aasland
erlend-aasland commented Feb 15, 2024
View reviewed changes
Tools/clinic/libclinic/identifiers.py
Copy link
ContributorAuthor

@erlend-aaslanderlend-aaslandFeb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexWaygood: interested in painting the name for this new bikeshed? 🎨 🚲

Copy link
ContributorAuthor

@erlend-aaslanderlend-aaslandFeb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identifiers.py it is! 🖌️

sobolevn
sobolevn approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@sobolevnsobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@erlend-aaslanderlend-aasland merged commit 351c103 into python:mainFeb 16, 2024
@erlend-aaslanderlend-aasland deleted the clinic/move-identifier-helpers branch February 16, 2024 06:42
@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commented Feb 16, 2024

Thanks for the review(s)!

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@erlend-aasland@woodruffw
pythongh-113317: Argument Clinic: move C/Py identifier helpers into l…
89ca440
…ibclinic (python#115520)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland@diegorusso
pythongh-113317: Argument Clinic: move C/Py identifier helpers into l…
14897ed
…ibclinic (python#115520)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@erlend-aasland@LukasWoodtli
pythongh-113317: Argument Clinic: move C/Py identifier helpers into l…
dc6433e
…ibclinic (python#115520)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevnsobolevnsobolevn approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@sobolevn