Skip to content

gh-113317: Argument Clinic: inline required_type_for_self_for_parser() in self converter#115522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
erlend-aasland merged 2 commits into from
Feb 15, 2024
Merged

gh-113317: Argument Clinic: inline required_type_for_self_for_parser() in self converter #115522

erlend-aasland merged 2 commits into from
Feb 15, 2024

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commented Feb 15, 2024•
edited by bedevere-app bot
Loading

@bedevere-appbedevere-appbot mentioned this pull request Feb 15, 2024
Closed
AlexWaygood
AlexWaygood approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some tiny nitpicks below:

@erlend-aasland@AlexWaygood
Update Tools/clinic/clinic.py
0bb5344
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aaslanderlend-aasland enabled auto-merge (squash) February 15, 2024 15:38
@erlend-aaslanderlend-aasland merged commit e74fa29 into python:mainFeb 15, 2024
@erlend-aaslanderlend-aasland deleted the clinic/inline_required_type_for_self_for_parser branch February 15, 2024 16:03
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland@AlexWaygood@diegorusso
pythongh-113317: Argument Clinic: inline required_type_for_self_for_p…
9226d4c
…arser() in self converter (python#115522) Co-authored-by: Alex Waygood <[email protected]>
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@erlend-aasland@AlexWaygood@LukasWoodtli
pythongh-113317: Argument Clinic: inline required_type_for_self_for_p…
28d512f
…arser() in self converter (python#115522) Co-authored-by: Alex Waygood <[email protected]>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@sobolevnsobolevnAwaiting requested review from sobolevn

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erlend-aasland@AlexWaygood