gh-114914: Avoid keeping dead StreamWriter alive#115661
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In some cases we might cause a StreamWriter to stay alive even when the application has dropped all references to it. This prevents us from doing automatical cleanup, and complaining that the StreamWriter wasn't properly closed. Fortunately, the extra reference was never actually used for anything so we can just drop it.
CendioOssman requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners
| addr=srv.sockets[0].getsockname() | ||
| withsocket.create_connection(addr): | ||
| # Give the loop some time to notice the connection | ||
| awaitasyncio.sleep(0.1) |
Member
There was a problem hiding this comment.
Like in the other PR, I believe that one or two sleep(0) should deterministically reach the state you're waiting for?
ContributorAuthor
There was a problem hiding this comment.
Three, actually.
But I'm cautious about this change. Right now, it seems to require three. But someone might change something so that tomorrow this requires four. At which point this test will start reporting "ok" even if everything is broken. :/
ContributorAuthor
There was a problem hiding this comment.
I think adding a future to wait on could give something more reliable in this specific case.
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum approved these changes Feb 28, 2024
Member
gvanrossum left a comment
gvanrossum left a comment There was a problem hiding this comment.
Looks great. Will merge. Thanks for finding and fixing this!
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Feb 28, 2024
In some cases we might cause a StreamWriter to stay alive even when the application has dropped all references to it. This prevents us from doing automatical cleanup, and complaining that the StreamWriter wasn't properly closed. Fortunately, the extra reference was never actually used for anything so we can just drop it.
Member
sobolevn commented Feb 29, 2024
Please, see #116112 |
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
In some cases we might cause a StreamWriter to stay alive even when the application has dropped all references to it. This prevents us from doing automatical cleanup, and complaining that the StreamWriter wasn't properly closed. Fortunately, the extra reference was never actually used for anything so we can just drop it.
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
In some cases we might cause a StreamWriter to stay alive even when the application has dropped all references to it. This prevents us from doing automatical cleanup, and complaining that the StreamWriter wasn't properly closed. Fortunately, the extra reference was never actually used for anything so we can just drop it.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
In some cases we might cause a StreamWriter to stay alive even when the application has dropped all references to it. This prevents us from doing automatical cleanup, and complaining that the StreamWriter wasn't properly closed. Fortunately, the extra reference was never actually used for anything so we can just drop it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases we might cause a StreamWriter to stay alive even when the application has dropped all references to it. This prevents us from doing automatical cleanup, and complaining that the StreamWriter wasn't properly closed.
Fortunately, the extra reference was never actually used for anything so we can just drop it.