Skip to content

GH-115651: Convert LOAD_MODULE_ATTR into LOAD_INLINE_CONST when the module is itself a constant.#115711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
markshannon merged 6 commits into from
Feb 22, 2024
Merged

GH-115651: Convert LOAD_MODULE_ATTR into LOAD_INLINE_CONST when the module is itself a constant. #115711

markshannon merged 6 commits into from
Feb 22, 2024

Conversation

@markshannon
Copy link
Member

@markshannonmarkshannon commented Feb 20, 2024•
edited by bedevere-app bot
Loading

Module attributes are global variables from other modules. It makes sense to convert them to constants as we already do for global variables.

@bedevere-appbedevere-appbot mentioned this pull request Feb 20, 2024
Closed
markshannon
markshannon commented Feb 20, 2024
View reviewed changes
Fidget-Spinner
Fidget-Spinner reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, just one change requested. Thanks!

Fidget-Spinner
Fidget-Spinner reviewed Feb 20, 2024
View reviewed changes
gvanrossum
gvanrossum reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@gvanrossumgvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some clarity concerns (based on how long it took me to follow what's happening here) but the basics look good, other than (I think) a missing break.

Fidget-Spinner
Fidget-Spinner approved these changes Feb 22, 2024
View reviewed changes
Copy link
Member

@Fidget-SpinnerFidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I just have a few questions

@markshannonmarkshannon merged commit b348313 into python:mainFeb 22, 2024
@markshannonmarkshannon deleted the load-attr-module-const branch March 1, 2024 15:29
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@markshannon@woodruffw
pythonGH-115651: ConvertLOAD_MODULE_ATTRintoLOAD_INLINE_CONST…
22bf92e
…when the module is itself a constant. (pythonGH-115711)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@markshannon@diegorusso
pythonGH-115651: ConvertLOAD_MODULE_ATTRintoLOAD_INLINE_CONST…
ecaee49
…when the module is itself a constant. (pythonGH-115711)
LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025
@markshannon@LukasWoodtli
pythonGH-115651: ConvertLOAD_MODULE_ATTRintoLOAD_INLINE_CONST…
8f854d1
…when the module is itself a constant. (pythonGH-115711)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum left review comments

@Fidget-SpinnerFidget-SpinnerFidget-Spinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markshannon@gvanrossum@Fidget-Spinner